Removed macros. #1457
Merged
Removed macros. #1457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1457 +/- ##
==========================================
- Coverage 98.57% 98.50% -0.07%
==========================================
Files 20 20
Lines 5749 5566 -183
==========================================
- Hits 5667 5483 -184
- Misses 82 83 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tleonhardt
approved these changes
Jul 4, 2025
| @@ -2753,99 +2723,6 @@ def combine_rl_history(statement: Statement) -> None: | |||
|
|
|||
| return statement | |||
|
|
|||
| def _input_line_to_statement(self, line: str, *, orig_rl_history_length: Optional[int] = None) -> Statement: | |||
There was a problem hiding this comment.
I forgot how much avoidable complexity macros added. Nice work surgically removing them. Everything here LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.